Correct type exports #810
Merged
Correct type exports #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify type import where only importing a type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #807
Unfortunately this issue doesn't show up in test builds since our test app doesn't use ts. Will need to consider a TypeScript testing strategy 🤔
Was able to repro the issue by creating ember app and installing
ember-cli-typescript.Corrected type exports by named (rather than default) exporting all public modules. Corrected a few instances where a full module was imported where only its type signature was used.
Also added a missing
typesVersionsfield topackage.json.I'm not very experienced with TypeScript or publishing types but this does fix all issues with the repro I created.