Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named export all modules #803

Merged
merged 4 commits into from
Jun 12, 2022
Merged

Named export all modules #803

merged 4 commits into from
Jun 12, 2022

Conversation

gilest
Copy link
Collaborator

@gilest gilest commented Jun 11, 2022

Updates the public API of all exported modules to be named exports from the top level.

Another breaking change but will give us more flexibility in the future to move files around etc.

@gilest gilest mentioned this pull request Jun 11, 2022
4 tasks
@gilest gilest force-pushed the feat/named-exports branch from 925ddb7 to 410f907 Compare June 11, 2022 03:13
Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change a lot. Makes teaching public API way easier if there is only one import path.

ember-file-upload/src/index.ts Outdated Show resolved Hide resolved
@gilest gilest force-pushed the feat/named-exports branch from 410f907 to 74c8559 Compare June 11, 2022 23:54
@gilest gilest force-pushed the feat/named-exports branch from 74c8559 to 6645790 Compare June 11, 2022 23:55
@gilest gilest merged commit dd5ef16 into master Jun 12, 2022
@gilest gilest deleted the feat/named-exports branch June 12, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants