Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve File.upload with a Response object #770

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

gilest
Copy link
Collaborator

@gilest gilest commented Apr 17, 2022

As requested in #546

Drops all implemented response parsers.

Ported header parsing logic to minimise change.

This means that File.upload() will return a Response.
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7719560
Status: ✅  Deploy successful!
Preview URL: https://4f2d220f.ember-file-upload.pages.dev

View logs

Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for picking this one up!

@gilest gilest merged commit 48c3b7e into master May 20, 2022
@gilest gilest deleted the fix/http-response branch May 20, 2022 03:29
@gilest gilest changed the title File.upload() returns Response Resolve File.upload with a Response object May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants