Migrate drag listener and parsers to typescript. Move all types definitions to interface file #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps to circumvent circular dependency issues in the Rollup build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the final pieces of internals that were still provided in js. Makes the upcoming v2 build much easier if all internal files are ts.
It's not the most elegant, especially as there is some cheeky duck-typing/synthetic stuff happening here. My ts experience is limited.
I've also moved all type definitions into a single interfaces file. This helps to avoid issues with circular dependency importing I've encountered downstream in the v2 addon branch.