Add cacheKeyForTree #273
Merged
Add cacheKeyForTree #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakesjews
reviewed
Aug 2, 2017
package.json
Outdated
| @@ -34,6 +34,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "broccoli-asset-rev": "^2.2.5", | |||
| "calculate-cache-key-for-tree": "^1.1.0", | |||
There was a problem hiding this comment.
Should this go in regular dependencies instead of dev?
thec0keman
force-pushed
the
add-cache-key-for-tree
branch
from
10470ae to
c9c61d9
Compare
|
@workmanw this looks good to me. Are you cool with merging this? |
|
Yup, thanks! |
|
Yeap. Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
cacheKeyForTreeas outlined in this RFC.See Ember Data#5110 for a more detailed explanation.