[WIP] Removes deprecation from upcoming Ember 2.12 release. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workmanw
force-pushed
the
factoryFor
branch
4 times, most recently
from
a39aabe to
54344d8
Compare
|
@jakesjews The upstream commit was cherry-picked into the beta channel. :). Okay to merge this one? After that, I'll rerun the tests with the other PR and then rebase it and we should be passing for the beta :). |
|
@workmanw sorry about the late response. Looks good 👍 |
|
@jakesjews No worries :) If you have a moment can you take a look at #232. |
|
@workmanw will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's hold on merging this until after Ember-Data's change lands in their beta channel. See: emberjs/data#4743 .