Make requireFiles do less work for larger applications #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a very large Ember application with loads of modules, so the
requireFiles
function takes a long time.This is because the
fileSeen
array is very long, but only a very small subset of these match thefilePattern
regex.The
filePattern
regex is very simple, but theexcludeRegex
is more complex. So if we evaluate the simple one first, we'll only have to evaluate the more complex one a much smaller number of times.I also took the opportunity to simplify the
excludeRegex
since it's the file extension that we really care about - at the end of the path.Time spent in
requireFiles
for one test module of our app before the change was 2605ms, time spent after the change was 70ms.