Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot record for Get requests #410

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Fix snapshot record for Get requests #410

merged 2 commits into from
Nov 18, 2019

Conversation

cinkonaap
Copy link
Contributor

@cinkonaap cinkonaap commented Nov 18, 2019

Related issue: #409
Problem:

While developing one of the tests in my app it turned out that when creating mocked find operation from already mocked model, like:

const user = make('user');
mockFindRecord(user);

the Snapshot object never had the record set to this model.

@danielspaniel danielspaniel merged commit 8b272ba into adopted-ember-addons:master Nov 18, 2019
@danielspaniel
Copy link
Collaborator

nice work @cinkonaap and @springerigor

@kbiedrzycki
Copy link

@danielspaniel any chance to publish new version including these changes soon?

@danielspaniel
Copy link
Collaborator

v3.9.5 is now released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants