Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedding records using deserialize: 'records' #200

Conversation

patocallaghan
Copy link
Collaborator

Currently factory-guy only supports embedding records using:

attrs: {
  reviews: {embedded: 'always'}
}

but Ember Data also allows you to embed records using:

attrs: {
  reviews: {deserialize: 'records'}
}

From the API docs

The attrs option for a resource { embedded: 'always' } is shorthand for: { serialize: 'records', deserialize: 'records' }

@patocallaghan patocallaghan force-pushed the patoc/embedded_serialize branch 2 times, most recently from 84c6275 to ffda1b1 Compare May 11, 2016 15:00
@patocallaghan patocallaghan force-pushed the patoc/embedded_serialize branch from ffda1b1 to 4a4e694 Compare May 11, 2016 15:01
@danielspaniel
Copy link
Collaborator

Good catch ..

@danielspaniel danielspaniel merged commit 943d91b into adopted-ember-addons:master May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants