Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ember-assign deprecation warning #479

Closed
drouhard opened this issue Jan 10, 2023 · 0 comments · Fixed by betterup/ember-data-factory-guy#1 or #481
Closed

Fix ember-assign deprecation warning #479

drouhard opened this issue Jan 10, 2023 · 0 comments · Fixed by betterup/ember-data-factory-guy#1 or #481

Comments

@drouhard
Copy link
Contributor

After updating to Ember 4 I am seeing thousands of these deprecation warnings coming from ember-data-factory-guy initializing.

https://github.com/emberjs/rfcs/blob/master/text/0750-deprecate-ember-assign.md

Fortunately the recommended solution is backwards-compatible and simple.
Replace this:

import { assign } from '@ember/polyfills';

with this:

import { assign as emberAssign } from '@ember/polyfills';

const assign = Object.assign || emberAssign;
drouhard added a commit to betterup/ember-data-factory-guy that referenced this issue Jan 10, 2023
@drouhard
Fix ember-assign deprecation
e86c284 
adopted-ember-addons#479
This was referenced Jan 10, 2023
Closed
Merged
drouhard added a commit to drouhard/ember-data-factory-guy that referenced this issue Jan 11, 2023
@drouhard
Replace polyfill assign with Object.assign
41cb912 
Removes deprecated code. See ember-polyfills.deprecate-assign
at https://deprecations.emberjs.com/v4.x and
adopted-ember-addons#479
for more context.

NOTE that Object.assign is not available in IE11, so this commit
removes some IE11 support.
@drouhard drouhard mentioned this issue Jan 11, 2023
Merged
drouhard added a commit to drouhard/ember-data-factory-guy that referenced this issue Jan 12, 2023
@drouhard
Replace polyfill assign with Object.assign
8a8c682 
Removes deprecated code. See ember-polyfills.deprecate-assign
at https://deprecations.emberjs.com/v4.x and
adopted-ember-addons#479
for more context.

NOTE that Object.assign is not available in IE11, so this commit
removes some IE11 support.
patocallaghan pushed a commit that referenced this issue Jan 13, 2023
@drouhard
Replace polyfill assign with Object.assign (#481)
c4ccbaa 
Removes deprecated code. See ember-polyfills.deprecate-assign
at https://deprecations.emberjs.com/v4.x and
#479
for more context.

NOTE that Object.assign is not available in IE11, so this commit
removes some IE11 support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@drouhard