-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ember 3.10, drops support for decorators #641
Support ember 3.10, drops support for decorators #641
Conversation
8e24bd9
to
8c49695
Compare
2935149
to
8ba9fec
Compare
This is passing on all scenarios except for beta and canary: I've opened an issue to track that: #642 |
We're running this in production for @intercom at the moment |
|
@GavinJoyce thanks for taking the time to resolve all of the current issues! Once this PR gets merged, I'll release a new beta version. If the decorator support has been causing so many issues, I say we remove it altogether and I'll make a note of it in the new beta version's changelog. Feel free to remove it completely if thats necessary to get this working in 3.10+. |
@offirgolan I've removed the remaining references to decorators, this should be good to go now |
Thanks @GavinJoyce! Released under |
Awesome work @GavinJoyce !!! |
Awesome work, thank you! |
Awesome. Thank you all! |
I'm seeing this bug with beta 9 and ember 3.10.2 Edit: IGNORE - npm had pulled in two versions of this addon |
extracted from GavinJoyce#1
fixes #640 and resolves some of the issues described in #635
This PR is a breaking change as it drops support for decorators which have proven somewhat unstable. They were introduced a year ago in #583 so they are likely used by some apps. A good path forward would be to create
ember-cp-validations-decorators
which can depend on this addon and provide decorators support.