This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix: use del-cli instead of del because it does not work under Windows
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR :) |
Julien-R44
added a commit
to JuliensForks/lucid
that referenced
this pull request
Jan 20, 2022
Julien-R44
added a commit
to JuliensForks/lucid
that referenced
this pull request
Jan 20, 2022
thetutlage
pushed a commit
to adonisjs/lucid
that referenced
this pull request
Feb 5, 2022
…nd `db:wipe` commands (#764) * feat: added migration:reset command * feat: added shouldCloseConnectionAfterMigrations in MigrationsBase * feat(commands): added migration:refresh * test(commands): added migration:refresh tests * fix: failing test on windows cause of path backslashes * chore: remove log * fix: use del-cli instead of del See : adonisjs/mrm-preset#25 * feat: add `dropAllTables` to QueryClient and TransactionClient * test: add failling test for exception raised when using `dropAllTables` with no tables in database * fix: `dropAllTables` should not raises exception when database is empty * test(commands): add test for db:wipe * feat(commands): add `db:wipe` command * feat(commands): add `migration:fresh` command * test(commands): add test for `migration:fresh` * chore: update description of new commands `force` flags * chore: update dryRun flags description of new commands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
delis already a builtin command on Windows, thenpm run cleancommand doesn't work as expected on Windows ( it asks for confirmation every time, which is really annoying 😅 ).See del-cli readme : https://github.com/sindresorhus/del-cli
This shouldn't change anything for the other platforms, because
del-cliis an alias : https://github.com/sindresorhus/del-cli/blob/main/package.json#L16