feat: drop postgres domain

[MaximeMRF]

Proposed changes

This pr allow you to drop postgres custom domain with node ace migration:fresh and also node ace db:wipe

It resolve this issue #948

Types of changes

What types of changes does your code introduce?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

Further comments

[RomainLanz]

Hey @MaximeMRF! 👋🏻

Could you please resolve the conflicts?

[Julien-R44]

i would say we should probably adding this logic directly to dropAllTypes() rather than making new dropAllDomains and getAllDomains methods.

in the end, there's very little difference between the domain and types. and if I take a step back, i would say i am expecting dropAllTypes to also drop domains.

what do you guys think?

[RomainLanz]

I am not sure what is a "domain" in PSQL land, so I need to read a bit more on those before deciding.

[mr-feek]

Thanks for the PR for the issue I filed @MaximeMRF !

I don't think there's much harm in being explicit about dropping domains vs. types.

Also, FWIW, I would assume this proposed change as-is would not be a breaking change (since we are being explicit, and dropTypes functionality remains the same), but adding it into dropTypes would be breaking change, right?

[MaximeMRF]

Hi @mr-feek

Agree with you, if people use dropTypes to drop types but don't know that it also drop domains it can be complicate to debug

[RomainLanz]

Cool, should we then merge this as-is? What do you think @thetutlage?

[RomainLanz]

Thanks @MaximeMRF!

[mr-feek]

Thanks all!