-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getAllViews
getAllTypes
dropAllTypes
and dropAllViews
functions
#784
feat: add getAllViews
getAllTypes
dropAllTypes
and dropAllViews
functions
#784
Conversation
…ethods to DialectContract interface and implementations
…ed warning for mssql and oracle
Dude. You are a beast. The tests are failing coz of some typing errors. You can please look into them? |
Thanks man! I love working on Adonis! |
it finally works, CI is back ! 👍 |
I am not sure about the I know it will add more work, but I believe it would be better to learn how to implement it in those DBMS and implement the feature right away. |
Yeah, I took the liberty of doing this because I noticed that this was also the case for other features in Oracle and MSSQL : Line 37 in 441d9b5
Line 79 in 441d9b5
And nobody had claimed their implementation in more than a year and a half. it seems that nobody uses these DB 😄 |
Looks good to me! Let's get it in |
Proposed changes
Add
getAllViews
getAllTypes
dropAllTypes
anddropAllViews
functions.Also added
dropTypes
anddropViews
flags indb:wipe
andmigration:fresh
commands, like suggested here : #764 (comment)Added cross-env for running tests from package.json
I'm doing a PR for the documentation right now 👍
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
For MSSQL and Oracle, I just threw an error in the new functions as a warning, I really don't know these DB so I leave that to someone else 😄