Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrator): step option #1023

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

MaximeMRF
Copy link
Contributor

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)

πŸ“š Description

  • Rollback the last migrations instead of rollback the firsts (that's make more sense)

  • Patch a little display bug due to the non-adaptation of this.migratedFiles at the step option

bug:
DeepinScreenshot_select-area_20240403171308

now:
DeepinScreenshot_select-area_20240403171553

@thetutlage
Copy link
Member

Sorry, I did not get the issue. Is it reversing the order in which migrations are reverted? Or is it something related to the way logs are displayed?

@MaximeMRF
Copy link
Contributor Author

Currently the migrator with the step flag rollback the migrations that are migrated firstly but it's make nonsens because we want to rollback the last ones.

And another problem was the display of the grey word "reverting" while all the concerning migrations was already reverted.

@thetutlage thetutlage merged commit b084678 into adonisjs:develop Apr 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants