feat: implement ignoreTables for sqlite

adonisjs · Sep 17, 2022 · 396cb88 · 396cb88
1 parent bbe2335
commit 396cb88
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/Dialects/SqliteBase.ts b/src/Dialects/SqliteBase.ts
@@ -9,7 +9,7 @@
 
 /// <reference path="../../adonis-typings/index.ts" />
 
-import { DialectContract, QueryClientContract } from '@ioc:Adonis/Lucid/Database'
+import { DialectContract, QueryClientContract, SqliteConfig } from '@ioc:Adonis/Lucid/Database'
 
 export abstract class BaseSqliteDialect implements DialectContract {
   public abstract readonly name: 'sqlite3' | 'better-sqlite3'
@@ -30,7 +30,7 @@ export abstract class BaseSqliteDialect implements DialectContract {
    */
   public readonly dateTimeFormat = 'yyyy-MM-dd HH:mm:ss'
 
-  constructor(private client: QueryClientContract) {}
+  constructor(private client: QueryClientContract, private config: SqliteConfig) {}
 
   /**
    * Returns an array of table names
@@ -81,9 +81,13 @@ export abstract class BaseSqliteDialect implements DialectContract {
    */
   public async dropAllTables() {
     await this.client.rawQuery('PRAGMA writable_schema = 1;')
-    await this.client.rawQuery(
-      `delete from sqlite_master where type in ('table', 'index', 'trigger');`
-    )
+    await this.client
+      .knexQuery()
+      .delete()
+      .from('sqlite_master')
+      .whereIn('type', ['table', 'index', 'trigger'])
+      .andWhereNot('name', this.config.wipe?.ignoreTables || [])
+
     await this.client.rawQuery('PRAGMA writable_schema = 0;')
     await this.client.rawQuery('VACUUM;')
   }

diff --git a/test/database/drop-tables.spec.ts b/test/database/drop-tables.spec.ts
@@ -114,5 +114,5 @@ test.group('Query client | drop tables', (group) => {
     assert.isTrue(await connection.client!.schema.hasTable('table_that_should_not_be_dropped'))
 
     await connection.disconnect()
-  }).skip(!['pg', 'mysql'].includes(process.env.DB!))
+  }).skip(!['pg', 'mysql', 'sqlite'].includes(process.env.DB!))
 })