fix(overlay): set overlay display flex so children render correctly #4969
+307
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Pull Request Test Coverage Report for Build 12150906883Details
💛 - Coveralls |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
Rajdeepc
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Amazing! Great catch!
nit: Would it be possible to create a reference test on the below test case to make sure the scroll also works in Webkit and Firefox engines which will make sure that we are not creating regressions on different browser contexts.
Please refer to this test
You can use the below API to test for Webkit engines:
import { isWebKit } from '@spectrum-web-components/shared';
Rajdeepc
previously approved these changes
Dec 3, 2024
|
Hi @caseyisonit and @Rajdeepc ! The flex css was specifically removed for this bug: Please see recordings attached. |
Rajdeepc
force-pushed
the
caseyisonit/SWC-609-overlay-scroll-bug
branch
from
4bf2a8a
to
49f36cb
Compare
|
https://caseyisonit-swc-609-overlay-scroll-bug--spectrum-web-components.netlify.app/storybook/iframe.html?args=&id=menu--default&viewMode=story in Safari is still cut off even with scroll. |
We should probably have tests for both #4902 and for this fix to prevent reversions. |
@AndreiBaicu26 I took a look at the recordings and that looks like it is a custom implementation. Based on the review link in this PR, the tooltip is rendering as expected, and I believe this Once this change is reverted, if you encounter the original bug you noticed before, we ask that you submit a GitHub issue and include an isolated code example that reproduces the bug. I will be reviewing our tests and screenshots covering these edge cases to make sure there is coverage to capture regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overlay needs a
display: flexapplied so that the children render correctly when they overflow the view height and can scroll.Resolves overflow and scrolling issues on Firefox and Safari for the following components:
Related issue(s)
Motivation and context
This allows users on Firefox and Safari to scroll and access all children in an overlay
How has this been tested?
Test case 1
Test case 2
Test case 3
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.