Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make scroll consistent in long popover vrts #4957

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@TarunAdobe TarunAdobe requested a review from a team as a code owner November 26, 2024 10:07
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 7d7c29e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Nov 26, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.98 0.97
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.61 kB 236.454 kB 🏆 236.753 kB
Scripts 61.56 kB 54.043 kB 🏆 54.282 kB
Stylesheet 54.12 kB 47.97 kB 🏆 48.001 kB
Document 6.223 kB 5.47 kB 5.467 kB 🏆
Font 126.842 kB 126.614 kB 🏆 126.651 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12144099320

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.191%

Totals Coverage Status
Change from base Build 12079841155: 0.0%
Covered Lines: 32397
Relevant Lines: 32817

💛 - Coveralls

Copy link

github-actions bot commented Nov 26, 2024

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 54.50ms - 55.75ms - faster ✔
3% - 6%
1.84ms - 3.64ms
branch 716 kB 57.22ms - 58.52ms slower ❌
3% - 7%
1.84ms - 3.64ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 141.16ms - 144.28ms - faster ✔
4% - 7%
6.33ms - 10.49ms
branch 918 kB 149.75ms - 152.50ms slower ❌
4% - 7%
6.33ms - 10.49ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 71.50ms - 72.81ms - faster ✔
4% - 7%
3.24ms - 5.74ms
branch 875 kB 75.59ms - 77.71ms slower ❌
4% - 8%
3.24ms - 5.74ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 69.78ms - 70.80ms - faster ✔
6% - 8%
4.33ms - 6.13ms
branch 874 kB 74.77ms - 76.26ms slower ❌
6% - 9%
4.33ms - 6.13ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1875.45ms - 1878.54ms - unsure 🔍
-0% - +0%
-2.90ms - +1.20ms
branch 1.05 MB 1876.50ms - 1879.20ms unsure 🔍
-0% - +0%
-1.20ms - +2.90ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1878.91ms - 1881.54ms - unsure 🔍
-0% - +0%
-1.69ms - +1.98ms
branch 1.05 MB 1878.80ms - 1881.36ms unsure 🔍
-0% - +0%
-1.98ms - +1.69ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 523.21ms - 528.19ms - faster ✔
3% - 4%
15.21ms - 23.19ms
branch 937 kB 541.79ms - 548.02ms slower ❌
3% - 4%
15.21ms - 23.19ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 42.48ms - 42.99ms - faster ✔
2% - 3%
0.72ms - 1.39ms
branch 959 kB 43.57ms - 44.01ms slower ❌
2% - 3%
0.72ms - 1.39ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 401.81ms - 406.06ms - faster ✔
2% - 4%
8.18ms - 15.83ms
branch 959 kB 412.76ms - 419.12ms slower ❌
2% - 4%
8.18ms - 15.83ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 53.46ms - 55.22ms - faster ✔
6% - 10%
3.55ms - 5.97ms
branch 899 kB 58.27ms - 59.93ms slower ❌
6% - 11%
3.55ms - 5.97ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 213.52ms - 215.83ms - faster ✔
2% - 4%
4.17ms - 9.75ms
branch 718 kB 219.10ms - 224.17ms slower ❌
2% - 5%
4.17ms - 9.75ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 982 kB 435.68ms - 439.28ms - faster ✔
0% - 1%
1.25ms - 6.46ms
branch 940 kB 439.46ms - 443.21ms slower ❌
0% - 1%
1.25ms - 6.46ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 26.54ms - 27.07ms - faster ✔
6% - 9%
1.58ms - 2.73ms
branch 1.02 MB 28.45ms - 29.47ms slower ❌
6% - 10%
1.58ms - 2.73ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 357.25ms - 360.95ms - faster ✔
2% - 4%
8.47ms - 13.33ms
branch 1.01 MB 368.43ms - 371.57ms slower ❌
2% - 4%
8.47ms - 13.33ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 45.09ms - 45.99ms - faster ✔
6% - 9%
3.09ms - 4.51ms
branch 806 kB 48.79ms - 49.89ms slower ❌
7% - 10%
3.09ms - 4.51ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 511.66ms - 518.41ms - faster ✔
4% - 7%
22.84ms - 36.08ms
branch 776 kB 538.80ms - 550.19ms slower ❌
4% - 7%
22.84ms - 36.08ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 108.51ms - 109.20ms - faster ✔
1% - 2%
1.27ms - 2.38ms
branch 775 kB 110.25ms - 111.11ms slower ❌
1% - 2%
1.27ms - 2.38ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 870 kB 36.49ms - 37.08ms - faster ✔
3% - 6%
1.31ms - 2.18ms
branch 828 kB 38.20ms - 38.85ms slower ❌
4% - 6%
1.31ms - 2.18ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.81ms - 26.32ms - faster ✔
7% - 10%
2.02ms - 2.79ms
branch 789 kB 28.18ms - 28.76ms slower ❌
8% - 11%
2.02ms - 2.79ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 54.10ms - 55.10ms - faster ✔
5% - 7%
2.83ms - 4.17ms
branch 912 kB 57.66ms - 58.54ms slower ❌
5% - 8%
2.83ms - 4.17ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 44.52ms - 45.31ms - faster ✔
6% - 9%
2.87ms - 4.25ms
branch 887 kB 47.91ms - 49.03ms slower ❌
6% - 9%
2.87ms - 4.25ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 63.35ms - 65.29ms - faster ✔
2% - 5%
1.25ms - 3.43ms
branch 763 kB 66.17ms - 67.14ms slower ❌
2% - 5%
1.25ms - 3.43ms
-
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 123.20ms - 132.08ms - unsure 🔍
-6% - +2%
-7.97ms - +2.89ms
branch 716 kB 127.06ms - 133.30ms unsure 🔍
-2% - +6%
-2.89ms - +7.97ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 297.95ms - 301.05ms - faster ✔
16% - 17%
55.56ms - 62.68ms
branch 918 kB 355.42ms - 361.82ms slower ❌
19% - 21%
55.56ms - 62.68ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 162.34ms - 167.90ms - slower ❌
1% - 6%
0.98ms - 9.46ms
branch 875 kB 156.71ms - 163.09ms faster ✔
1% - 6%
0.98ms - 9.46ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 142.40ms - 149.96ms - faster ✔
1% - 7%
0.82ms - 11.10ms
branch 874 kB 148.65ms - 155.63ms slower ❌
0% - 8%
0.82ms - 11.10ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1901.97ms - 1907.91ms - unsure 🔍
-0% - +0%
-7.62ms - +0.74ms
branch 1.05 MB 1905.44ms - 1911.32ms unsure 🔍
-0% - +0%
-0.74ms - +7.62ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1908.73ms - 1911.79ms - faster ✔
0% - 1%
8.68ms - 15.92ms
branch 1.05 MB 1919.28ms - 1925.84ms slower ❌
0% - 1%
8.68ms - 15.92ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 872.07ms - 893.53ms - faster ✔
1% - 4%
10.73ms - 35.07ms
branch 937 kB 899.95ms - 911.45ms slower ❌
1% - 4%
10.73ms - 35.07ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 73.44ms - 75.96ms - faster ✔
2% - 8%
1.15ms - 6.17ms
branch 959 kB 76.18ms - 80.54ms slower ❌
1% - 8%
1.15ms - 6.17ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 795.80ms - 807.56ms - slower ❌
4% - 7%
28.93ms - 55.91ms
branch 959 kB 747.11ms - 771.41ms faster ✔
4% - 7%
28.93ms - 55.91ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 115.95ms - 122.21ms - faster ✔
0% - 7%
0.52ms - 9.12ms
branch 899 kB 120.95ms - 126.85ms slower ❌
0% - 8%
0.52ms - 9.12ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 414.10ms - 429.06ms - faster ✔
1% - 6%
5.20ms - 26.52ms
branch 718 kB 429.85ms - 445.03ms slower ❌
1% - 6%
5.20ms - 26.52ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 762.07ms - 779.53ms - slower ❌
7% - 10%
49.69ms - 73.87ms
branch 1.02 MB 700.65ms - 717.39ms faster ✔
7% - 10%
49.69ms - 73.87ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 54.73ms - 55.67ms - faster ✔
2% - 5%
1.06ms - 3.02ms
branch 1.02 MB 56.38ms - 58.10ms slower ❌
2% - 5%
1.06ms - 3.02ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 755.08ms - 780.44ms - slower ❌
7% - 11%
49.50ms - 79.90ms
branch 1.01 MB 694.68ms - 711.44ms faster ✔
7% - 10%
49.50ms - 79.90ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 96.79ms - 99.01ms - faster ✔
5% - 8%
5.19ms - 8.77ms
branch 806 kB 103.48ms - 106.28ms slower ❌
5% - 9%
5.19ms - 8.77ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 1050.68ms - 1079.76ms - faster ✔
3% - 6%
37.72ms - 69.04ms
branch 776 kB 1112.80ms - 1124.40ms slower ❌
3% - 7%
37.72ms - 69.04ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 156.77ms - 165.39ms - unsure 🔍
-7% - +2%
-11.61ms - +2.85ms
branch 775 kB 159.66ms - 171.26ms unsure 🔍
-2% - +7%
-2.85ms - +11.61ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 82.97ms - 90.07ms - slower ❌
2% - 12%
1.86ms - 9.66ms
branch 912 kB 79.15ms - 82.37ms faster ✔
2% - 11%
1.86ms - 9.66ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 52.59ms - 53.25ms - faster ✔
2% - 4%
1.18ms - 2.10ms
branch 789 kB 54.25ms - 54.87ms slower ❌
2% - 4%
1.18ms - 2.10ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 158.38ms - 164.30ms - slower ❌
14% - 20%
18.99ms - 27.05ms
branch 912 kB 135.59ms - 141.05ms faster ✔
12% - 17%
18.99ms - 27.05ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 92.28ms - 95.24ms - faster ✔
24% - 30%
29.18ms - 39.26ms
branch 887 kB 123.16ms - 132.80ms slower ❌
31% - 42%
29.18ms - 39.26ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 123.43ms - 131.05ms - unsure 🔍
-6% - +2%
-7.60ms - +2.76ms
branch 763 kB 126.15ms - 133.17ms unsure 🔍
-2% - +6%
-2.76ms - +7.60ms
-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants