fix(combobox): correct value to itemText interchange when something is "selected" #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsCurrently, no packages are changed by this PR... |
hunterloftis
approved these changes
Feb 2, 2024
Westbrook
pushed a commit
that referenced
this pull request
Feb 2, 2024
* feat(combobox): begin working branch for combobox additions * feat(combobox): add size attribute (#3887) * feat(combobox): wip * chore: update sizes and stories * chore: add isoverlayopen decorator to stories --------- Co-authored-by: Westbrook Johnson <[email protected]> Co-authored-by: Najika Yoo <[email protected]> * chore: add benchmark test for lightdom combobox (#3898) * chore: add benchmark test for lightdom combobox * chore: add object version of benchmark test * chore: rename files --------- Co-authored-by: Najika Yoo <[email protected]> * test(combobox): update data management tests for current API * test(combobox): get more tests passing and skip tests that will be visited in future work (#3919) * test(combobox): get more tests passing and skip tests that will be visited in future work * ci: update golden images cache * test(combobox): ignore Combobox Item code * chore(combobox): cleanup unused code (#3922) * chore(combobox): cleanup unused code * ci: update golden images cache * fix(combobox): add support for external tooltip elements (#3930) * fix(combobox): add support for external tooltip elements * chore(combobox): remove unused code paths * ci: update golden images cache * docs(combobox): include slot present in API docs * fix(combobox): allow intern Menu to hold a selection when autocomplete === "none" (#3951) * test(combobox): add accessibility tests (#3953) * chore: add labels to combobox input * chore: get tests passing * test(combobox): get a11y tests passing * chore: remove unused positionlistbox method * test: get tests passing, change spelling of activeDescendant * chore: missed some descendents * chore: add help text demo and test * ci: update hash * chore: address review comments * chore: abstract shared data to index files * test(combobox): update tests and stories to use legible data * ci: update hash * chore: label menu and rename stories * ci: update hash --------- Co-authored-by: Najika Yoo <[email protected]> * test(combobox): fulfil accessibility contract (#3974) * chore: add tooltip to ariadescribedby * test(combobox): add a11y test for tooltip --------- Co-authored-by: Najika Yoo <[email protected]> * chore(bundle): include combobox * chore(combobox): clean up property availability and types * chore(combobox): clean up property availability and type * refactor(combobox): update ComboboxOption type * ci: update golden images cache * refactor(combobox): simplify typing and correct query location when moving items into viewport * docs: use human useful content in stories * ci: update golden images cache * refactor(combobox): default "autocomplete" to "none" * docs: correct story configuration * docs(combobox): create initial documentation * docs(combobox): apply docs feedback * docs(combobox): use only working examples in live mode * fix(combobox): maintain focus on input element when toggling menu * docs(combobox): improve clarity * ci: update golden images cache * docs(combobox): add story demonstrating controlled-component usage (#3988) * docs(combobox): add story demonstrating controlled-component usage * Update packages/combobox/stories/combobox.stories.ts Co-authored-by: Westbrook Johnson <[email protected]> --------- Co-authored-by: Westbrook Johnson <[email protected]> * fix(combobox): add support for "readonly" and "disabled" * docs(textfield): expand on attribute/property descriptions * fix(combobox): add support for "readonly" and "disabled" * ci: update golden images cache * fix(textfield): prevent outline on :focus-visible elements that are disabled * fix(combobox): correct value to itemText interchange when something is "selected" (#3994) --------- Co-authored-by: Najika Halsema Yoo <[email protected]> Co-authored-by: Najika Yoo <[email protected]> Co-authored-by: Hunter Loftis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
correct value to itemText interchange when something is "selected"
How has this been tested?
alinto the ComboboxAfghanistaninto the ComboboxTypes of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.