Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-bar): actionBar after actionButton 3257 #3457

Closed
wants to merge 1 commit into from

Conversation

blunteshwar
Copy link
Collaborator

@blunteshwar blunteshwar commented Jul 18, 2023

Description

the action-bar was appearing before the action-button which opens it so I corrected this order by placing the action-bar after the action-button that opens it in example because sp-actionbar should follow the button that expands or collapses it. So that the sp-actionbar renders in a logical tab order rather than before the button, which forces the user to Shift+Tab or navigate backwards using a screen reader to find it.

Related issue(s)

Motivation and context

How has this been tested?

Using Dev Tools(see screenshot attached)

  • Test case 1
    1. Go here
    2. Do this
  • Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

Screenshot 2023-07-18 at 1 46 53 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions
Copy link

Tachometer results

Chrome

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 369 kB 36.26ms - 37.28ms - unsure 🔍
-1% - +3%
-0.32ms - +0.93ms
branch 370 kB 36.11ms - 36.82ms unsure 🔍
-3% - +1%
-0.93ms - +0.32ms
-
Firefox

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 369 kB 184.27ms - 218.09ms - unsure 🔍
-11% - +12%
-20.92ms - +23.56ms
branch 370 kB 185.41ms - 214.31ms unsure 🔍
-12% - +10%
-23.56ms - +20.92ms
-

@Westbrook
Copy link
Contributor

Closing as a duplicate of #2639 as there is a larger refactor of the element played out therein.

Of note, there are two instances of this addressed in that PR: https://github.com/adobe/spectrum-web-components/pull/2639/files#diff-760591fcd861f949acad051b0c05c85d2471d81b9c02757437e3ccc9f63f95f5

@Westbrook Westbrook closed this Jul 18, 2023
@Westbrook Westbrook deleted the bug/ActionBar-3257 branch November 2, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants