fix(color-slider): sp-color-slider fails to announce new value on change after keydown #3303 #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
added
a11y
1 task
Tachometer resultsChromecolor-slider permalink
Firefoxcolor-slider permalink
|
Westbrook
reviewed
Jun 30, 2023
Westbrook
reviewed
Jul 11, 2023
Westbrook
force-pushed
the
Issue-3303-color-slider-a11y
branch
from
9767fd8 to
d705c44
Compare
Westbrook
reviewed
Jul 11, 2023
| @@ -350,7 +363,8 @@ describe('ColorSlider', () => { | |||
|
|
|||
| await elementUpdated(el); | |||
|
|
|||
| expect(el.sliderHandlePosition).to.equal(20); | |||
| expect(el.sliderHandlePosition).to.equal((20 * 100) / 360); | |||
There was a problem hiding this comment.
I was gonna merge this through, but JS is having a JS moment on this value not equaling itself. The uniformity here made it nicer to read and easier to understand. I'm gonna check around for a similar alternative, but this PR is good to go, otherwise.
Westbrook
force-pushed
the
Issue-3303-color-slider-a11y
branch
from
d705c44 to
d81e9d5
Compare
Westbrook
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.