Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create an empty cache by including extra key data when loading cache #3131

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Westbrook
Copy link
Contributor

Description

As per google/wireit#71 the Wireit cache can grow... forever. This negates the caching benefits in CircleCI when you need to load/save many MB of data after a couple of weeks of leveraging the cache. This PR creates a parameter that can be passed the build so that when pointed to someting other than the default the cache will not get loaded and the install workflow will create a new cache from scratch. It is possible to inject a parameter as part of a chron based triggering of a CircleCI, so I've scheduled a weekly run that creates a new cache so that we can benefit from the speed of the caching generally without allowing the cache to grow to large. If at some point the issue in question is addressed and there is a "wireit-native" cache management strategy, then we can remove this workaround.

How has this been tested?

  • Test case 1
    1. I manually cleared the cache and runs returned to their previous performance metrics
  • Test case 2
    1. The job is scheduled to be triggered from this branch on Monday morning UTC.
    2. Confirm that the cache is once again created at the expected size.
    3. If so, update the trigger to run against main and merge this PR.

Types of changes

  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

Branch Preview

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Tachometer results

Currently, no packages are changed by this PR...

@Westbrook Westbrook force-pushed the bust-cache branch 2 times, most recently from 861c09e to 3c94921 Compare April 27, 2023 16:55
@Westbrook Westbrook merged commit 039c68b into main Apr 27, 2023
@Westbrook Westbrook deleted the bust-cache branch April 27, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants