fix: keep parent overlays open when not closing child hover overlays #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChromeaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
Westbrook
force-pushed
the
overlay-stack-mangement
branch
from
a17cd78 to
eabad5e
Compare
hunterloftis
previously approved these changes
Nov 10, 2022
| @@ -611,9 +611,11 @@ export class OverlayStack { | |||
| while (index && overlaysToClose.length === 0) { | |||
| index -= 1; | |||
| const overlay = this.overlays[index]; | |||
| const path = event.composedPath(); | |||
There was a problem hiding this comment.
I may not understand what's being checked here enough to label it properly, but consider something like this?
Suggested change
| const path = event.composedPath(); | |
| const path = event.composedPath(); | |
| const isOutsideTriggerAndContent = (!path.includes(overlay.trigger) || overlay.interaction !== 'hover') && !path.includes(overlay.overlayContent; |
There was a problem hiding this comment.
Good call. The naming here is hard, but I've paired it with an update comment from the change that broke this, so hopefully it's more understandable in the future.
Comment on lines
616
to
618
| (!path.includes(overlay.trigger) || | ||
| overlay.interaction !== 'hover') && | ||
| !path.includes(overlay.overlayContent) |
There was a problem hiding this comment.
Suggested change
| (!path.includes(overlay.trigger) || | |
| overlay.interaction !== 'hover') && | |
| !path.includes(overlay.overlayContent) | |
| isOutsideTriggerAndContent |
Westbrook
force-pushed
the
overlay-stack-mangement
branch
from
eabad5e to
8919e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent clicks within ancestor overlays from closing those ancestor overlays.
Related issue(s)
How has this been tested?
Types of changes
Checklist