Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove "npm run" references in README #246

Merged
merged 1 commit into from
Oct 8, 2019
Merged

docs: remove "npm run" references in README #246

merged 1 commit into from
Oct 8, 2019

Conversation

Westbrook
Copy link
Contributor

Description

The README had some confusing references to npm run ... that needed to be updated to yarn ...

Motivation and Context

Clarity for a new user.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Westbrook Westbrook requested a review from beeduul October 8, 2019 19:15
beeduul
beeduul approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@beeduul beeduul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer! and more correct ;)

@Westbrook Westbrook merged commit 10de932 into master Oct 8, 2019
@Westbrook Westbrook deleted the westbrook/readme branch October 8, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeduul beeduul beeduul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Westbrook @beeduul