fix: normalize wheel input directionally for more predictable input #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
So, I tested this with my mouse (I actually have a scroll wheel!!!) and it works great, save for the inversion. I saw that you mentioned that in your issue linked to this that you attempted to try and fix that... Is that still something we can't resolve? If not, I think it's fine as is, but we may want to denote that in the docs, create a separate issue, etc.
|
Indeed. If there is a path to altering that later on, we'll come back to this. Also, I corrected the issue that this PR closes so that we can continue to track the direction question past this fix. |
najikahalsema
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use wheel directionally rather than based on "distance" for more predictable input.
Related Issue
fixes #1531
Motivation and Context
Users should not be surprised.
How Has This Been Tested?
Unit tests.
Screenshots (if appropriate):
https://westbrook-numberfield-wheel-step--spectrum-web-components.netlify.app/components/number-field
Types of changes
Checklist: