Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update scripts to better support windows based development #1443

Merged
merged 1 commit into from
May 10, 2021

Conversation

Westbrook
Copy link
Contributor

Description

Update scripting so that it is more compatible with the windows development environment.

Related Issue

fixes #909

Motivation and Context

It should be easier for windows users to contribute from a windows environment

How Has This Been Tested?

Windows VM on Virtual Box

Types of changes

  • Scripting updates

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Westbrook Westbrook force-pushed the westbrook/windows branch from 8229da1 to 744ed8a Compare May 10, 2021 21:45
Copy link
Contributor

@benjamind benjamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on a clean windows install, build and ran storybook, looks good!

@Westbrook Westbrook merged commit 6ddfa34 into main May 10, 2021
@Westbrook Westbrook deleted the westbrook/windows branch May 10, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install/build the project on Windows
2 participants