Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: sp-split-button more button should be labelled by button element #3305

Closed
1 task done
jnurthen opened this issue Jun 9, 2023 · 1 comment · Fixed by #3354
Closed
1 task done

[Bug]: sp-split-button more button should be labelled by button element #3305

jnurthen opened this issue Jun 9, 2023 · 1 comment · Fixed by #3354
Assignees
@jnurthen
Labels
a11y Issues related to accessibility bug Something isn't working triage An issue needing triage

Comments

@jnurthen
Copy link
Member

jnurthen commented Jun 9, 2023

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-split-button

Expected behavior

The popup button part of the split button should be labelled by the button part

Actual behavior

It is currently labelled a hardcoded "More"

Screenshots

No response

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/split-button/#sizes
  2. Right Click on the More button and inspect the Accessibility Properties

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response
@jnurthen jnurthen added bug Something isn't working a11y Issues related to accessibility triage An issue needing triage labels Jun 9, 2023
@jnurthen
Copy link
Member Author

jnurthen commented Jun 9, 2023

Having the same label isn't an issue as one will be read as a menu button (or a button with a popup) and one is a simple button.

@jnurthen jnurthen mentioned this issue Jun 22, 2023
Closed
1 task
@jnurthen jnurthen self-assigned this Jun 22, 2023
jnurthen added a commit that referenced this issue Jun 22, 2023
@jnurthen
fix: sp-split-button more button label
609dfbb 
Fixes #3305
@jnurthen jnurthen mentioned this issue Jun 22, 2023
Merged
12 tasks
Westbrook pushed a commit that referenced this issue Jul 13, 2023
@jnurthen @Westbrook
fix: sp-split-button more button label
8176d5d 
Fixes #3305
Westbrook pushed a commit that referenced this issue Jul 18, 2023
@jnurthen
fix: sp-split-button more button label
a38c66d 
Fixes #3305
Westbrook pushed a commit that referenced this issue Jul 25, 2023
@jnurthen
fix: sp-split-button more button label
32d281c 
Fixes #3305
Westbrook added a commit that referenced this issue Jul 25, 2023
@jnurthen @Westbrook
fix(split-button): update more button label application (#3354)
b4c9595 
* fix: sp-split-button more button label
Fixes #3305

* test: handle "buttonmenu" usage in Firefox

---------

Co-authored-by: Westbrook Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

Labels
a11y Issues related to accessibility bug Something isn't working triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sp-split-button more button label adobe/spectrum-web-components
1 participant
@jnurthen