[Feat]: Support 'pending' button states #3162
Assignees
Labels
Component: Button
enhancement
New feature or request
help wanted
Extra attention is needed
Spectrum Engineering
Comments
benjamind
added
enhancement
benjamind
added a commit
that referenced
this issue
Apr 28, 2023
benjamind
added a commit
that referenced
this issue
Apr 28, 2023
11 tasks
benjamind
added a commit
that referenced
this issue
Sep 13, 2023
benjamind
added a commit
that referenced
this issue
Sep 13, 2023
najikahalsema
added
help wanted
|
WIP PR: #3163 |
|
@benjamind I see a PR opened by you on this. Would you like us to take this forward from you or do you have some plans to land this. Let me know what works best for you so that we can add this to our upcoming sprint. |
|
By all means please take this forward, I don't think I'll have time to land it any time soon! Thanks! |
Westbrook
pushed a commit
that referenced
this issue
Jan 5, 2024
* feat(button): adds pending button, fixes #3162 * chore(button): import sp-progress-circle whenever required * chore: updated golden image hash * chore(button): updated aria-label on changing pending state * chore(button): removed redudant styles and functions * chore(button): added tshirt sizing to the progress-circle * chore(button): removed isPending state * chore(button): update aria-label on pending toggle * chore: updated golden image hash * chore(button): removed ispending and timeout * chore(button): updated css animation names * chore(button): update aria-label on removing pending * chore(button): added docs for pending state * chore: updated golden image hash * chore(button): update arialabel on disabled change in pending state * chore: updated golden image hash * fix(button): updated aria-label management in button * fix(button): fixed aria-label management and added more tests * fix(button): revert back the aria-label management logic in ButtonBase * chore: updated golden image hash * fix(button): shifted aria-label management to updated in button * chore: udpated golden image hash * chore: updated golden image hash * chore(button): improved code readability --------- Co-authored-by: TarunAdobe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of conduct
Impacted component(s)
button
Description of the requested feature
We should implement the 'pending' button state as described here: https://spectrum.adobe.com/page/button/#Pending
Mockups or screenshots
No response
Implementation notes or ideas
No response
The text was updated successfully, but these errors were encountered: