build: update Spectrum CSS processing for less errors and better cove…

…rage
adobe · Jan 4, 2021 · 8e5ec9b · 8e5ec9b
1 parent 925934a
commit 8e5ec9b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/packages/action-group/src/spectrum-config.js b/packages/action-group/src/spectrum-config.js
@@ -65,6 +65,7 @@ const config = {
                     selector: '.spectrum-ActionGroup-item.focus-ring',
                 },
             ],
+            exclude: [/\.spectrum-ActionButton-label/],
         },
     ],
 };

diff --git a/packages/menu/src/menu-item.css b/packages/menu/src/menu-item.css
@@ -19,3 +19,8 @@ governing permissions and limitations under the License.
 #selected {
     flex-shrink: 0;
 }
+
+::slotted(sp-menu) {
+    /* .spectrum-Menu .spectrum-Menu */
+    display: block;
+}
diff --git a/packages/menu/src/spectrum-config.js b/packages/menu/src/spectrum-config.js
@@ -33,6 +33,12 @@ const config = {
                 /\.spectrum-Menu-checkmark/,
                 /\.spectrum-Menu-chevron/,
             ],
+            complexSelectors: [
+                {
+                    replacement: '::slotted(sp-menu)',
+                    selector: '.spectrum-Menu .spectrum-Menu',
+                },
+            ],
         },
         {
             name: 'menu-item',

diff --git a/packages/menu/src/spectrum-menu.css b/packages/menu/src/spectrum-menu.css
@@ -28,7 +28,7 @@ THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
     list-style-type: none;
     overflow: auto;
 }
-:host {
+::slotted(sp-menu) {
     /* .spectrum-Menu .spectrum-Menu */
     display: block;
 }

diff --git a/scripts/process-spectrum-postcss-plugin.js b/scripts/process-spectrum-postcss-plugin.js
@@ -208,7 +208,7 @@ class SpectrumProcessor {
                     // e.g. `.valid .selector, ::slotted(.invalid) .selector {}` would be lost.
                     isInvalidSelector = true;
                     this.warn(
-                        `:slotted() rules must be the last in the selector`,
+                        `:slotted() rules must be the last in the selector: ${selector}`,
                         {
                             node: rule,
                         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -65,6 +65,7 @@ const config = { @@
                         selector: '.spectrum-ActionGroup-item.focus-ring',
                     },
                 ],
+                exclude: [/\.spectrum-ActionButton-label/],
             },
         ],
     };
@@ Expand Down @@