Skip to content

Commit

Permalink
feat(tabs-overflow): fix style and update unittest
Browse files Browse the repository at this point in the history
  • Loading branch information
monkeyjabs authored and Westbrook committed Feb 16, 2023
1 parent 8c92ae9 commit 59843df
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
10 changes: 5 additions & 5 deletions packages/tabs-overflow/src/tabs-overflow.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,26 @@ governing permissions and limitations under the License.
--sp-tabs-overflow-button-size: var(
--spectrum-global-dimension-static-size-500
);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-450);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-500);
--sp-tabs-overflow-icon-color: var(--spectrum-gray-800);
--sp-tabs-overflow-shadow-color: var(--spectrum-gray-100);
--sp-tabs-overflow-shadow-width: 50px;
}

:host([size='s']) {
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-450);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-500);
}

:host([size='m']) {
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-550);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-600);
}

:host([size='l']) {
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-650);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-700);
}

:host([size='xl']) {
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-750);
--sp-tabs-overflow-button-height: var(--spectrum-global-dimension-size-800);
}

sp-action-button {
Expand Down
6 changes: 2 additions & 4 deletions packages/tabs-overflow/test/tabs-overflow.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ describe('TabsOverflow', () => {
const spTabsOverflows: TabsOverflow = el.querySelector(
'sp-tabs-overflow'
) as TabsOverflow;
const overflowContainerEl = spTabsOverflows.shadowRoot.querySelector(
'.tabs-overflow-container'
) as HTMLDivElement;
expect(overflowContainerEl.classList[1]).to.equal('m');

expect(spTabsOverflows.getAttribute('size')).to.equal('m');
});
});

0 comments on commit 59843df

Please sign in to comment.