fix: manage updated node types

adobe · Oct 18, 2022 · 0517fc1 · 0517fc1
1 parent 7c92324
commit 0517fc1
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/packages/icon/src/Icon.ts b/packages/icon/src/Icon.ts
@@ -29,7 +29,7 @@ export class Icon extends IconBase {
     public src?: string;
 
     @property()
-    public name?: string;
+    public override name?: string;
 
     @query('#container')
     private iconContainer?: HTMLElement;

diff --git a/packages/iconset/src/iconset.ts b/packages/iconset/src/iconset.ts
@@ -37,7 +37,7 @@ export abstract class Iconset extends LitElement {
      * to consuming icons.
      */
     @property()
-    public set name(value: string) {
+    public override set name(value: string) {
         // if we're already registered in the iconset registry
         // we'll need to update our registration
         if (this.registered) {
@@ -53,7 +53,7 @@ export abstract class Iconset extends LitElement {
         }
         this._name = value;
     }
-    public get name(): string {
+    public override get name(): string {
         return this._name;
     }
 

diff --git a/packages/iconset/stories/icons-demo.ts b/packages/iconset/stories/icons-demo.ts
@@ -66,7 +66,7 @@ export class DelayedReady extends SpectrumElement {
 @customElement('icons-demo')
 export class IconsDemo extends SpectrumElement {
     @property()
-    public name = 'ui';
+    public override name = 'ui';
 
     @property()
     public package = '';

diff --git a/packages/radio/src/RadioGroup.ts b/packages/radio/src/RadioGroup.ts
@@ -32,7 +32,7 @@ import { RovingTabindexController } from '@spectrum-web-components/reactive-cont
  */
 export class RadioGroup extends FocusVisiblePolyfillMixin(FieldGroup) {
     @property({ type: String })
-    public name = '';
+    public override name = '';
 
     @queryAssignedNodes('')
     public defaultNodes!: Node[];

diff --git a/packages/slider/src/SliderHandle.ts b/packages/slider/src/SliderHandle.ts
@@ -98,7 +98,7 @@ export class SliderHandle extends Focusable {
     public highlight = false;
 
     @property({ type: String })
-    public name = '';
+    public override name = '';
 
     @property({ reflect: true, converter: MinConverter })
     public min?: number | 'previous';

diff --git a/tools/reactive-controllers/src/FocusGroup.ts b/tools/reactive-controllers/src/FocusGroup.ts
@@ -128,7 +128,7 @@ export class FocusGroupController<T extends HTMLElement>
         if (typeof listenerScope === 'object') {
             this._listenerScope = () => listenerScope;
         } else if (typeof listenerScope === 'function') {
-            this._listenerScope = listenerScope;
+            this._listenerScope = listenerScope as () => HTMLElement;
         }
     }