feat(card): overflow hidden on cover photo for swc implementation #2661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds overflow hidden to the .spectrum-Card-coverPhoto class, to help resolve an issue in the SWC implementation that uses sp-asset.
In SWC the photo could appear from behind the corners of the card. For example, when increasing the corner rounding when setting the mod --mod-card-corner-radius. This issue is not visible in Spectrum CSS. This overflow property used to exist in SWC as a CSS override, but is preferred to exist here in CSS.
Example of the issue in SWC:
Set
--mod-card-corner-radius: 24px
on the sp-card in the first example on the SWC docs site:Setting
overflow: hidden
on the#cover-photo
selector via the inspector fixes the issue. The spectrum-config in SWC converts our class to that ID (converter.classToId('spectrum-Card-coverPhoto', 'cover-photo')
).CSS-734
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list