Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add utility api for forms metrics #566

Merged
merged 1 commit into from
Feb 3, 2025
Merged

feat: add utility api for forms metrics #566

merged 1 commit into from
Feb 3, 2025

Conversation

nit23uec
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

Copy link

This PR will trigger a minor release when merged.

@nit23uec nit23uec requested a review from solaris007 January 30, 2025 17:22
@solaris007
Copy link
Member

@nit23uec i am not sure spacecat-shared-utils is the right place for forms-specific utils, as the tools herein are rather generic and use-case independent. not that i have a better idea currently :)

@nit23uec
Copy link
Contributor Author

@nit23uec i am not sure spacecat-shared-utils is the right place for forms-specific utils, as the tools herein are rather generic and use-case independent. not that i have a better idea currently :)

Thanks for the review @solaris007 . These methods are expected to be used atleast in audit worker and reporting worker. So, it would be useful to park them at a common location to avoid duplication.
Should I create a new package (spacecat-shared-forms) for this use case?

@solaris007 solaris007 merged commit a7365b6 into main Feb 3, 2025
7 checks passed
@solaris007 solaris007 deleted the forms-oppty branch February 3, 2025 09:46
solaris007 pushed a commit that referenced this pull request Feb 3, 2025
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants