Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generify site and organization config #142

Merged
merged 11 commits into from
Feb 15, 2024
Merged

fix: generify site and organization config #142

merged 11 commits into from
Feb 15, 2024

Conversation

alinarublea
Copy link
Contributor

@alinarublea alinarublea commented Feb 8, 2024

In the context of the import worker we need to store and retrieve the ingest configuration. Currently the site and configuration config return only the slack and alerts configuration and with this changes they will return the complete configuration

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06f4f90) 100.00% compared to head (b0b5346) 100.00%.
Report is 36 commits behind head on main.

❗ Current head b0b5346 differs from pull request most recent head b461acf. Consider uploading reports for the commit b461acf to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         3772      3763    -9     
=========================================
- Hits          3772      3763    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 8, 2024

This PR will trigger a minor release when merged.

@alinarublea alinarublea marked this pull request as ready for review February 15, 2024 13:25
@alinarublea alinarublea changed the title fix: fix config map fix: generify site and organization config Feb 15, 2024
@alinarublea alinarublea merged commit 0ec8ee1 into main Feb 15, 2024
6 checks passed
@alinarublea alinarublea deleted the fix-audits branch February 15, 2024 13:49
@adobe-bot
Copy link

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants