Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rum client createRUMURL function #137

Merged
merged 9 commits into from
Feb 6, 2024
Merged

feat: rum client createRUMURL function #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
317ca32
feat: add rum api calls to shared
alinarublea Dec 13, 2023
2ce1404
feat: merge main changes
alinarublea Jan 22, 2024
5c2390e
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Jan 24, 2024
641f735
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Jan 24, 2024
c9fc3d1
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Jan 29, 2024
f007a5f
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Jan 29, 2024
f09c2f6
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Jan 30, 2024
966d79d
Merge branch 'main' of github.com:adobe/spacecat-shared
alinarublea Feb 6, 2024
624fc20
feat: expose create RUM url for storing cwv as an audit
alinarublea Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions packages/spacecat-shared-rum-api-client/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,21 @@ export default class RUMAPIClient {
);
}

async getRUMDashboard(params = {}) {
return sendRequest(createUrl(
createRUMURL(params = {}) {
return createUrl(
APIS.RUM_DASHBOARD,
{ domainkey: this.domainkey, ...RUM_DEFAULT_PARAMS, ...params },
));
{
domainkey: this.domainkey, ...RUM_DEFAULT_PARAMS, ...params,
},
);
}

async getRUMDashboard(params = {}) {
return sendRequest(this.createRUMURL(params));
}

async get404Sources(params = {}) {
return sendRequest(this.create404URL(
params,
));
return sendRequest(this.create404URL(params));
}

async getDomainList(params = {}) {
Expand Down
6 changes: 6 additions & 0 deletions packages/spacecat-shared-rum-api-client/test/rum-api-client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ describe('rum api client', () => {
.to.eql('https://helix-pages.anywhere.run/helix-services/run-query@v3/rum-sources?domainkey=hebele&interval=7&offset=0&limit=101&checkpoint=404&url=http%3A%2F%2Fspacecar.com');
});

it('returns the URL to call the getRUMDashboard', () => {
const rumApiClient = RUMAPIClient.createFrom({ env: { RUM_DOMAIN_KEY: 'hebele' } });
expect(rumApiClient.createRUMURL({ url: 'http://spacecar.com' }))
.to.eql('https://helix-pages.anywhere.run/helix-services/run-query@v3/rum-dashboard?domainkey=hebele&interval=7&offset=0&limit=101&url=http%3A%2F%2Fspacecar.com');
});

it('returns data when get404Sources api is successful', async () => {
nock('https://helix-pages.anywhere.run/helix-services')
.get('/run-query@v3/rum-sources')
Expand Down
Loading