feat: experimentation RUM API method #133

raji-unni · 2024-02-06T09:46:56Z

…xperimentation data

Please ensure your pull request adheres to the following guidelines:

make sure to link the related issues in this description
when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

…xperimentation data

github-actions · 2024-02-06T10:16:36Z

This PR will trigger a minor release when merged.

…SITES-18784 Merged the latest changes from main branch

codecov · 2024-02-06T10:33:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52ec442) 100.00% compared to head (06f4f90) 100.00%.
Report is 16 commits behind head on main.

❗ Current head 06f4f90 differs from pull request most recent head edd5d08. Consider uploading reports for the commit edd5d08 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main      #133    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           36        37     +1     
  Lines         3605      3772   +167     
==========================================
+ Hits          3605      3772   +167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ekremney · 2024-02-06T10:48:59Z

packages/spacecat-shared-rum-api-client/src/index.js

+  createExperimentationURL(params = {}) {
+    return createUrl(
+      APIS.RUM_EXPERIMENTS,
+      {
+        domainkey: this.domainkey, ...RUM_DEFAULT_PARAMS, ...params,
+      },
+    );
+  }
+


it should rather be:

Suggested change

createExperimentationURL(params = {}) {

return createUrl(

APIS.RUM_EXPERIMENTS,

{

domainkey: this.domainkey, ...RUM_DEFAULT_PARAMS, ...params,

},

);

}

async getExperimentation(params = {}) {

return sendRequest(createUrl(

APIS.RUM_EXPERIMENTS,

{ domainkey: this.domainkey, ...RUM_DEFAULT_PARAMS, ...params },

));

}

so that, consumer of this API can use the method like:

rumAPIClient.getExperimentation({ url: 'www.adobe.com' });

Ekrem, I am only trying to get a url from the function which I will be calling from the handler. So I have done some changes. Please check.

Have implemented the changes as discussed with you.

…SITES-18784 Getting the latest changes from the main branch.

…SITES-18784 Get the latest changes from the main branch.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [codecov/codecov-action](https://togithub.com/codecov/codecov-action) | action | major | `v3` -> `v4` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/codecov%2fcodecov-action/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/codecov%2fcodecov-action/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/codecov%2fcodecov-action/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/codecov%2fcodecov-action/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [dynamo-db-local](https://togithub.com/chrisguttandin/dynamo-db-local) | devDependencies | major | [`7.3.0` -> `8.0.0`](https://renovatebot.com/diffs/npm/dynamo-db-local/7.3.0/8.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/dynamo-db-local/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/dynamo-db-local/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/dynamo-db-local/7.3.0/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/dynamo-db-local/7.3.0/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>codecov/codecov-action (codecov/codecov-action)</summary> ### [`v4`](https://togithub.com/codecov/codecov-action/compare/v3...v4) [Compare Source](https://togithub.com/codecov/codecov-action/compare/v3...v4) </details> <details> <summary>chrisguttandin/dynamo-db-local (dynamo-db-local)</summary> ### [`v8.0.0`](https://togithub.com/chrisguttandin/dynamo-db-local/releases/tag/v8.0.0) [Compare Source](https://togithub.com/chrisguttandin/dynamo-db-local/compare/v7.3.0...v8.0.0) [all commits](https://togithub.com/chrisguttandin/dynamo-db-local/compare/v7.3.0...v8.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/adobe/spacecat-shared).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Adding this function to be able to use it to store it as fullAuditRef for the cwv audit

# [@adobe/spacecat-shared-rum-api-client-v1.5.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v1.4.4...@adobe/spacecat-shared-rum-api-client-v1.5.0) (2024-02-06) ### Features * rum client createRUMURL function ([0c68dcc](0c68dcc))

Co-authored-by: Dominique Jäggi <[email protected]>

# [@adobe/spacecat-shared-utils-v1.10.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.9.0...@adobe/spacecat-shared-utils-v1.10.0) (2024-02-07) ### Features * move sqs wrapper to scpacecat-shared ([#136](#136)) ([b9f6d75](b9f6d75))

# [@adobe/spacecat-shared-utils-v1.11.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.10.0...@adobe/spacecat-shared-utils-v1.11.0) (2024-02-07) ### Features * url helpers in utils ([#139](#139)) ([0a90c1b](0a90c1b))

# [@adobe/spacecat-shared-data-access-v1.15.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.15.0...@adobe/spacecat-shared-data-access-v1.15.1) (2024-02-07) ### Bug Fixes * retrieve site candidate by base url ([#140](#140)) ([b37cb0b](b37cb0b))

…into SITES-18784

# [@adobe/spacecat-shared-rum-api-client-v1.6.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v1.5.0...@adobe/spacecat-shared-rum-api-client-v1.6.0) (2024-02-07) ### Features * experimentation RUM API method ([#133](#133)) ([f95eded](f95eded))

adobe-bot · 2024-02-07T15:44:50Z

🎉 This PR is included in version @adobe/spacecat-shared-rum-api-client-v1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Changes for including Experimentation RUM API url call for fetching E…

16602c9

…xperimentation data

raji-unni requested review from alinarublea and ekremney February 6, 2024 09:47

Fixed the errors introduced in the earlier commit

7e8ad81

Merge branch 'main' of https://github.com/adobe/spacecat-shared into …

68e5ccd

…SITES-18784 Merged the latest changes from main branch

ekremney reviewed Feb 6, 2024

View reviewed changes

raji-unni added 5 commits February 6, 2024 16:23

Merge branch 'main' of https://github.com/adobe/spacecat-shared into …

7c426c3

…SITES-18784 Getting the latest changes from the main branch.

Changes as per the review comments.

1ed9839

Removed the unwanted test

de18715

Merge branch 'main' of https://github.com/adobe/spacecat-shared into …

3ce1106

…SITES-18784 Get the latest changes from the main branch.

Implementing the experiments RUM API call to get the response.

06f4f90

ekremney changed the title ~~feat: Changes for including Experimentation RUM API url call for fetching E…~~ feat: experimentation RUM API method Feb 6, 2024

ekremney approved these changes Feb 6, 2024

View reviewed changes

renovate bot and others added 10 commits February 6, 2024 15:58

feat: rum client createRUMURL function

0c68dcc

Adding this function to be able to use it to store it as fullAuditRef for the cwv audit

feat: move sqs wrapper to scpacecat-shared (#136)

b9f6d75

Co-authored-by: Dominique Jäggi <[email protected]>

feat: url helpers in utils (#139)

0a90c1b

fix: retrieve site candidate by base url (#140)

b37cb0b

Merge branch 'SITES-18784' of https://github.com/adobe/spacecat-shared …

edd5d08

…into SITES-18784

raji-unni merged commit f95eded into main Feb 7, 2024
6 checks passed

raji-unni deleted the SITES-18784 branch February 7, 2024 15:37

adobe-bot added the released label Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: experimentation RUM API method #133

feat: experimentation RUM API method #133

raji-unni commented Feb 6, 2024

github-actions bot commented Feb 6, 2024 •

edited

Loading

codecov bot commented Feb 6, 2024 •

edited

Loading

ekremney Feb 6, 2024

raji-unni Feb 6, 2024

raji-unni Feb 6, 2024

adobe-bot commented Feb 7, 2024

feat: experimentation RUM API method #133

feat: experimentation RUM API method #133

Conversation

raji-unni commented Feb 6, 2024

Related Issues

github-actions bot commented Feb 6, 2024 • edited Loading

codecov bot commented Feb 6, 2024 • edited Loading

Codecov Report

ekremney Feb 6, 2024

Choose a reason for hiding this comment

raji-unni Feb 6, 2024

Choose a reason for hiding this comment

raji-unni Feb 6, 2024

Choose a reason for hiding this comment

adobe-bot commented Feb 7, 2024

github-actions bot commented Feb 6, 2024 •

edited

Loading

codecov bot commented Feb 6, 2024 •

edited

Loading