-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: site candidate data model #126
Conversation
This PR will trigger a minor release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 31 35 +4
Lines 3311 3563 +252
==========================================
+ Hits 3311 3563 +252 ☔ View full report in Codecov by Sentry. |
packages/spacecat-shared-data-access/src/models/site-candidate.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/service/site-candidates/accessPatterns.js
Show resolved
Hide resolved
one question: RUM is the first site detection source, but there will be many others, such as CM and XWALK, both of which will include organization information when reporting a site for detection. should we include an organization hint and if yielding a particular organization associate the approved site with it / create the organization? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff
# [@adobe/spacecat-shared-data-access-v1.14.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.13.2...@adobe/spacecat-shared-data-access-v1.14.0) (2024-02-02) ### Features * site candidate data model ([#126](#126)) ([c457645](c457645))
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Site Candidate Data Model
This PR introduces the Site Candidate Data Model to manage the site discovery flow. The primary objective is to maintain a comprehensive list of new sites and their respective statuses for potential inclusion in the Star Catalogue. The information is stored in the
site-candidates
table. The PR contains the data model itself, along with the access patterns and the functions which are used to add and modify of site candidates.Flow
site-candidates
table to ascertain whether the site has been previously discovered.site-candidates
table with the statusPENDING
Subsequently, Spacecat will dispatch a discovery slack message containing the URL of the newly discovered site. This message will include interactive options with
[Yes]
and[Ignore]
buttons, enabling human decision-making regarding the addition of the site to the Star Catalogue.If a user clicks
[Yes]
, Spacecat will further update the status toAPPROVED
and proceed with adding the site to the Star Catalogue.If a user clicks
[Ignore]
, Spacecat will update the status toIGNORED
and not add the site to Star Catalogue.If any error happens during the process, Spacecat will update the status to
ERROR