Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default value for disabled property of audit config #114

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

iuliag
Copy link
Contributor

@iuliag iuliag commented Jan 26, 2024

SEO-related audit types should have default value for disabled true (we enable one by one the sites, so we don't waste Ahrefs API units on sites not of interest at this post.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

Copy link

This PR will trigger a minor release when merged.

@iuliag iuliag marked this pull request as ready for review January 26, 2024 15:36
@iuliag iuliag requested review from dzehnder and solaris007 January 26, 2024 15:36
@iuliag iuliag merged commit daf9b80 into main Jan 29, 2024
6 checks passed
@iuliag iuliag deleted the audit-type-disabled-default branch January 29, 2024 10:10
adobe-bot pushed a commit that referenced this pull request Jan 29, 2024
# [@adobe/spacecat-shared-data-access-v1.11.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.10.5...@adobe/spacecat-shared-data-access-v1.11.0) (2024-01-29)

### Features

* default value for disabled property of audit config ([#114](#114)) ([daf9b80](daf9b80))
@adobe-bot
Copy link

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants