fix: move slack status defs

adobe · Feb 1, 2024 · 8a351fb · 8a351fb
1 parent ac6f532
commit 8a351fb
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 13 deletions.
diff --git a/packages/spacecat-shared-slack-client/src/clients/elevated-slack-client.js b/packages/spacecat-shared-slack-client/src/clients/elevated-slack-client.js
@@ -18,18 +18,6 @@ import SlackUser from '../models/slack-user.js';
 
 import BaseSlackClient from './base-slack-client.js';
 
-/**
- * The possible statuses for a user invites and channel creations.
- *
- * @type {{
- * USER_ALREADY_IN_CHANNEL: string,
- * GENERAL_ERROR: string,
- * USER_ALREADY_IN_ANOTHER_CHANNEL: string,
- * USER_INVITED_TO_CHANNEL: string,
- * USER_NEEDS_INVITATION_TO_WORKSPACE: string,
- * CHANNEL_ALREADY_EXISTS: string
- * }}
- */
 export const SLACK_STATUSES = {
   USER_ALREADY_IN_CHANNEL: 'user_already_in_channel',
   USER_ALREADY_IN_ANOTHER_CHANNEL: 'user_already_in_another_channel',

diff --git a/packages/spacecat-shared-slack-client/src/index.d.ts b/packages/spacecat-shared-slack-client/src/index.d.ts
@@ -18,6 +18,18 @@ export declare const SLACK_TARGETS: {
   ADOBE_EXTERNAL: string;
 };
 
+/**
+ * The possible statuses for a user invites and channel creations.
+ */
+export declare const SLACK_STATUSES : {
+  USER_ALREADY_IN_CHANNEL: string;
+  GENERAL_ERROR: string;
+  USER_ALREADY_IN_ANOTHER_CHANNEL: string;
+  USER_INVITED_TO_CHANNEL: string;
+  USER_NEEDS_INVITATION_TO_WORKSPACE: string;
+  CHANNEL_ALREADY_EXISTS: string;
+};
+
 export {
   BaseSlackClient,
   ElevatedSlackClient,

diff --git a/packages/spacecat-shared-slack-client/src/index.js b/packages/spacecat-shared-slack-client/src/index.js
@@ -11,14 +11,15 @@
  */
 
 import BaseSlackClient from './clients/base-slack-client.js';
-import ElevatedSlackClient from './clients/elevated-slack-client.js';
+import ElevatedSlackClient, { SLACK_STATUSES } from './clients/elevated-slack-client.js';
 
 const SLACK_TARGETS = {
   ADOBE_INTERNAL: 'ADOBE_INTERNAL',
   ADOBE_EXTERNAL: 'ADOBE_EXTERNAL',
 };
 
 export {
+  SLACK_STATUSES,
   SLACK_TARGETS,
   BaseSlackClient,
   ElevatedSlackClient,

diff --git a/packages/spacecat-shared-slack-client/test/index.test.js b/packages/spacecat-shared-slack-client/test/index.test.js
@@ -14,6 +14,7 @@
 
 import { expect } from 'chai';
 import {
+  SLACK_STATUSES,
   SLACK_TARGETS,
   BaseSlackClient,
   ElevatedSlackClient,
@@ -24,6 +25,17 @@ describe('SLACK_TARGETS Object', () => {
     expect(SLACK_TARGETS).to.be.an('object').that.includes.all.keys('ADOBE_INTERNAL', 'ADOBE_EXTERNAL');
   });
 
+  it('SLACK_STATUSES must have required properties', () => {
+    expect(SLACK_STATUSES).to.be.an('object').that.includes.all.keys(
+      'USER_ALREADY_IN_CHANNEL',
+      'GENERAL_ERROR',
+      'USER_ALREADY_IN_ANOTHER_CHANNEL',
+      'USER_INVITED_TO_CHANNEL',
+      'USER_NEEDS_INVITATION_TO_WORKSPACE',
+      'CHANNEL_ALREADY_EXISTS',
+    );
+  });
+
   it('should have correct values for properties', () => {
     expect(SLACK_TARGETS.ADOBE_INTERNAL).to.equal('ADOBE_INTERNAL');
     expect(SLACK_TARGETS.ADOBE_EXTERNAL).to.equal('ADOBE_EXTERNAL');