Remove deprecated querystring dependency. #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
querystring
dependency. It is deprecated and no longer maintained.Related Issue
Motivation and Context
alloy
uses@adobe/reactor-query-string
as a dependency. We added a custom build script foralloy
. When we run that script withnpx
, we see a warning saying thatquerystring
is deprecated. We want to get rid of that warning. This PR uses URLSearchParams. I added a few tests to make sure the change is backward compatible.A few of the differences between querystring and URLSearchParams can be found here.
Even if the changes should be compatible, I will release these as a new major version.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: