Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated querystring dependency. #170

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

dompuiu
Copy link
Member

@dompuiu dompuiu commented Jun 24, 2024

Description

Remove the querystring dependency. It is deprecated and no longer maintained.

Related Issue

Motivation and Context

alloy uses @adobe/reactor-query-string as a dependency. We added a custom build script for alloy. When we run that script with npx, we see a warning saying that querystring is deprecated. We want to get rid of that warning. This PR uses URLSearchParams. I added a few tests to make sure the change is backward compatible.

A few of the differences between querystring and URLSearchParams can be found here.

Even if the changes should be compatible, I will release these as a new major version.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dompuiu dompuiu merged commit 89f6b1b into master Jun 25, 2024
4 checks passed
@dompuiu dompuiu deleted the remove_query_strings_dependency branch June 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants