chore: Update TreeView API #7613
Conversation
| children | ||
| } = props; | ||
| let {isDetached, isEmphasized} = useContext(InternalTreeContext); | ||
| let {hasChildItems} = useContext(TreeItemContext); |
There was a problem hiding this comment.
hasChildRows in the render props doesn't give you what you need?
There was a problem hiding this comment.
apparently i do need this right now, I'll look into it more tomorrow
There was a problem hiding this comment.
I believe it is for the case where you want to mark a TreeRow as expandable despite not having any child rows (aka async case/permissions case where the user doesn't have access to said TreeRow's content but needs to know that it is expanded)
There was a problem hiding this comment.
yeah, was just looking into it and was scratching my head why this was needed and clearly intentional because there are tests for it as well
There was a problem hiding this comment.
Probably should be done in RAC then. This won't result in the right aria attributes being added, only the visual chevron appearing. There is a hasChildNodes property internally, maybe that should be used instead?
| @@ -414,6 +471,10 @@ The `<TreeViewItem>` component works with frameworks and client side routers lik | |||
|
|
|||
| <PropTable component={docs.exports.TreeView} links={docs.links} style={{marginBottom: '40px'}} /> | |||
|
|
|||
| ### TreeItemContent props | |||
|
|
|||
| <PropTable component={docs.exports.TreeItemContent} links={docs.links} style={{marginBottom: '40px'}} /> | |||
There was a problem hiding this comment.
Not quite sure why, but this section doesn't seem to render anything
snowystinger
dismissed stale reviews from LFDanLu and devongovett
The base branch was changed.
snowystinger
force-pushed
the
s2-treeview-api-update
branch
from
23a6b1a to
04adce4
Compare
## API Changes
@react-spectrum/s2/@react-spectrum/s2:TreeItemContent+TreeItemContent {
+
+}@react-spectrum/tree/@react-spectrum/tree:TreeItemContent+TreeItemContent {
+
+}/@react-spectrum/tree:Collection+Collection <T extends {}> {
+ addIdAndValue?: boolean
+ children?: ReactNode | ({}) => ReactNode
+ dependencies?: Array<any>
+ idScope?: Key
+ items?: Iterable<{}>
+} |
Closes
I think this is what https://github.com/orgs/adobe/projects/19/views/32?visibleFields=%5B%22Title%22%2C%22Assignees%22%2C%22Status%22%2C4406231%2C25365423%2C3244152%2C5195578%2C17851188%2C30557450%2C3404283%2C%22Labels%22%5D&filterQuery=&pane=issue&itemId=59197979
was asking for
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: