-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: useTag hook #7394
base: main
Are you sure you want to change the base?
fix: useTag hook #7394
Conversation
}, | ||
rowProps: mergeProps(rowProps, domProps, linkProps, { | ||
tabIndex: (isFocused || state.selectionManager.focusedKey == null) ? 0 : -1, | ||
tabIndex: getTabIndex(isDisabled, isFocused, isNonFocused), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the opportunity to resolve this issue.
I solved an issue where the TabGroup component was deleted when it was disalbed.
I don't think it's a good code, but if there is a better code or something wrong, please point it out. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks like you've run prettier or something equivalent over the file. Would you mind undoing that so that we can review the actual change? right now there is a bunch of noise and things that will fail our lint. Thanks again!
@snowystinger Thank you for your help. Edit completed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update!
Would you mind adding a test for this?
@snowystinger I wrote this by referring to the useTagGroup hook test. I'm not good at writing test code, so I'm worried about whether it's written well. If there is anything that needs correction, could you please mention it? thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a go at that. So that you know why I changed it, I focused on the behavior instead of the implementation. So interacted with the test in the same way a user would in the real world since it was reproducible there.
It was a good start though and I appreciate it. Looks good now.
Closes #7080
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: