Satisfy new yarn peer behavior #6767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
changed the title
snowystinger
commented
Jul 25, 2024
snowystinger
commented
Jul 25, 2024
| @@ -0,0 +1,40 @@ | |||
|
|
|||
There was a problem hiding this comment.
these are all versions which can't be easily changed through the yarn cli like we do with react, react-dom at the root level, but it's just helping to tie down certain versions so we don't have duplicates installed and they are all versions which work with the react version we've installed
snowystinger
changed the title
1 similar comment
# Conflicts: # yarn.lock
# Conflicts: # package.json # yarn.lock
devongovett
approved these changes
Aug 8, 2024
| @@ -52,7 +52,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@adobe/spectrum-css-temp": "3.0.0-alpha.1", | |||
| "@react-spectrum/test-utils-internal": "3.0.0-alpha.1" | |||
| "@react-spectrum/test-utils-internal": "3.0.0-alpha.1", | |||
| "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0" | |||
There was a problem hiding this comment.
why only react-dom and not react?
There was a problem hiding this comment.
react is already in the peerDeps, so something else will supply it
nothing is 'technically' supplying react-dom, which the test-utils-internal are requesting, so had to add react-dom here just for dev work
LFDanLu
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Followup from yarn 4 PR. This reduces the warnings we get about unmet peers.
There are still a handful outstanding, but they rely on external packages to update
Not hopeful about this one
GoogleChromeLabs/quicklink#421
Need to update to newest storybook
storybookjs/storybook#26960
The one about webpack peer is misleading but only because we're using that module in a non-documented way
https://github.com/hipstersmoothie/react-docgen-typescript-plugin
Either we could contribute to the project to see if it can be separated or we can just live with the peer warning. Oddly and thankfully it does not appear to install the peer.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: