-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storybook actions depth to 2 #6386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snowystinger 2 seemed reasonable and performance was noticeably improved. I just tried 1 and it seems to behave the same as 2. I think this is a bug in 7.0: storybookjs/storybook#21933. I also tried 0 and it seems like the depth didn't apply at all in that case. |
## API Changes
unknown top level export { type: 'any' } |
This should help fix a noticeable lag after the Storybook 7 upgrade.
Note that the depth can be overridden at the individual action level, if we ever do want more depth for specific actions.
✅ Pull Request Checklist:
📝 Test Instructions:
Test by opening a Combobox in storybook:
Before Change
After Change
🧢 Your Project:
RSP