Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure checkboxes without explicit values render no value attribute in the DOM #3554

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

brandonpittman
Copy link
Contributor

This handles the issue with default checkboxes getting values of '' instead
of 'on' as noted here.

  • Fix useToggle value when undefined
  • Add tests for default checkbox values

Closes #3519

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Create checkbox without an explicit value and check that there's no value
attribute attached to it in the DOM.

🧢 Your Project:

Splink Inc.

@brandonpittman brandonpittman force-pushed the fix/default-checkbox-values branch from a770519 to 9332e7c Compare September 26, 2022 05:47
@brandonpittman brandonpittman force-pushed the fix/default-checkbox-values branch from 9332e7c to a64c26b Compare September 26, 2022 05:58
snowystinger
snowystinger previously approved these changes Sep 26, 2022
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a test to Switch as well.

Ensure `null` values are ignored as well as `undefined` ones.

Co-authored-by: Daniel Lu <[email protected]>
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is the value of a checkbox using useCheckbox '' instead of 'on'?
3 participants