Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: line selection highlighting #443

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rich-b
Copy link

@rich-b rich-b commented Oct 21, 2024

Description

Adds selection highlight support to Line charts

Related Issue

#374

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rich-b rich-b changed the title line selection highlighting feat: line selection highlighting Oct 21, 2024
Copy link

@marshallpete
Copy link
Member

Do you mind adding a story that demonstrates this feature?

@rich-b
Copy link
Author

rich-b commented Oct 24, 2024

@marshallpete the existing story already demonstrates this. the ChartPopover -> LineChart story has a UNSAFE_highlightBy control. It can be set to item(default), series, or dimension. This is the same as what we already have for the ChartPopover -> StackedBarChart story

@majornista
Copy link

I think "line highlighting" highlight the line, by drawing a stroke outline, rather than all the points in the line? Screen shot showing a Vega-Chart with a line highlighted using a stroke outline

I'm thinking of the use case where there are hundreds of points in a condensed space, so that highlighted points would overlap.

@marshallpete
Copy link
Member

Good callout @majornista . With spectrum 2 changes we will be re-evaluating all the hover, focus and select states. I think we can revisit then.

@marshallpete marshallpete merged commit 9f3514f into adobe:main Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants