Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: center donut summary without label #350

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: center donut summary without label #350

merged 1 commit into from
Jun 13, 2024

Conversation

marshallpete
Copy link
Member

Description

Center the donut summary value when there isn't a label.

Related Issue

#218

Story:

Donut > DonutSummary > NoLabel

Screenshots (if appropriate):

Was:
image

Is:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-350

@tanugarg04 tanugarg04 merged commit d5e8019 into main Jun 13, 2024
4 checks passed
@tanugarg04 tanugarg04 deleted the centerDonutSummary branch June 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanugarg04 tanugarg04 tanugarg04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marshallpete @tanugarg04