Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donut segment label #347

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Donut segment label #347

merged 3 commits into from
Jun 12, 2024

Conversation

marshallpete
Copy link
Member

Description

Update the API, breaking out segment labels.

was:

...
  <Donut hasDirectLabels />
...

is:

...
  <Donut>
    <SegmentLabel percent value valueFormat="shortNumber" />
  </Donut>
...

New API gives far more control.

New support for:

  • display or hide percent
  • display or hide value
  • value number format
  • key in the data to use for the label

Related Issue

#218

Motivation and Context

Stories:

Donut > SegmentLabel

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marshallpete
Copy link
Member Author

This is an alpha component so breaking changes are ok

@marshallpete
Copy link
Member Author

Don't need to update docs yet. Will do when it goes to RC. (later this week)

Copy link

Copy link

@marshallpete marshallpete merged commit 30fe41e into main Jun 12, 2024
4 checks passed
@marshallpete marshallpete deleted the donutSegmentLabel branch June 12, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants