Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donut selection ring #341

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Donut selection ring #341

merged 3 commits into from
Jun 5, 2024

Conversation

marshallpete
Copy link
Member

Description

Add selection ring to donut.

Related Issue

#218

Motivation and Context

All of our chart types have some kind of selection ring when selected. This will update donut to be consistent.

Stories

ChartPopover > DonutChart
Donut > WithPopover

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

github-actions bot commented Jun 5, 2024

Copy link

sonarqubecloud bot commented Jun 5, 2024

Copy link

github-actions bot commented Jun 5, 2024

Copy link
Contributor

@Bryant-Curtis Bryant-Curtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@Bryant-Curtis Bryant-Curtis merged commit 5748c99 into main Jun 5, 2024
5 checks passed
@Bryant-Curtis Bryant-Curtis deleted the donutSelectionRing branch June 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants