$ref does not work recursively

[MatthiasPichler]

What did you do

I tried to generate markdown files for the schemata below by running npx jsonschema2md -d ./schemas -o ./out

What did you expect to happen

That all references were resolved to the second schema.

What happened

Only references on the first and second level were resolved.

What's your environment

• Operating System: Ubuntu 19.04
• node.js version: 12.0.0

Do you have example files:

For these schemata:

./schemas/core.schema.json

{
  "$id": "https://example.org/core",
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "nested": {
      "type": "object",
      "properties": {
        "reference": {
          "$ref": "https://example.org/ext#"
        }
      }
    },
    "deep": {
      "type": "object",
      "properties": {
        "deeper": {
          "type": "object",
          "properties": {
            "reference": {
              "$ref": "https://example.org/ext#"
            }
          }
        }
      }
    },
    "first": {
      "$ref": "https://example.org/ext#"
    }
  },
  "required": [],
  "additionalProperties": false
}

./schemas/ext.schema.json

{
  "$id": "https://example.org/ext",
  "$schema": "http://json-schema.org/draft-07/schema#",
  "title": "Baz",
  "type": "string",
  "enum": ["foo", "bar"]
}

I'm getting following Markdown

# Schema

https://example.org/core

| Abstract            | Extensible | Status       | Identifiable | Custom Properties | Additional Properties | Defined In                           |
| ------------------- | ---------- | ------------ | ------------ | ----------------- | --------------------- | ------------------------------------ |
| Can be instantiated | No         | Experimental | No           | Forbidden         | Forbidden             | [core.schema.json](core.schema.json) |

## Schema Hierarchy

- `https://example.org/core`
- [Baz](ext.schema.md) `https://example.org/ext`

# Properties

| Property          | Type     | Required | Nullable | Defined by    |
| ----------------- | -------- | -------- | -------- | ------------- |
| [deep](#deep)     | `object` | Optional | No       | (this schema) |
| [first](#first)   | Baz      | Optional | No       | (this schema) |
| [nested](#nested) | `object` | Optional | No       | (this schema) |

## deep

`deep`

- is optional
- type: `object`
- defined in this schema

### deep Type

`object` with following properties:

| Property | Type   | Required |
| -------- | ------ | -------- |
| `deeper` | object | Optional |

#### deeper

`deeper`

- is optional
- type: `object`

##### deeper Type

`object` with following properties:

| Property    | Type | Required |
| ----------- | ---- | -------- |
| `reference` |      | Optional |

#### reference

`reference`

- is optional
- type: reference

##### reference Type

- []() – `https://example.org/ext#`

## first

`first`

- is optional
- type: Baz
- defined in this schema

### first Type

- [Baz](ext.schema.md) – `https://example.org/ext#`

## nested

`nested`

- is optional
- type: `object`
- defined in this schema

### nested Type

`object` with following properties:

| Property    | Type | Required |
| ----------- | ---- | -------- |
| `reference` | Baz  | Optional |

#### reference

`reference`

- is optional
- type: Baz

##### reference Type

- [Baz](ext.schema.md) – `https://example.org/ext#`

[MatthiasPichler]

the following log was created:

07
info: output directory: /home/username/Downloads/schema-test/out
info: finished reading all *.schema.json files in /home/username/Downloads/schema-test/schemas, beginning processing….
/home/username/Downloads/schema-test/schemas/core.schema.json
unresolved reference: https://example.org/ext#
/home/username/Downloads/schema-test/schemas/ext.schema.json
Output processed. Trying to make a README.md now
Writing README
info: Processing complete.

So only one unresolved reference was logged (which is correct)

[MatthiasPichler]

I just opened #156 to fix this

[trieloff]

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀